← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1083218] Re: oslo changes to logging_context_format_string not compatible with nova

 

** Changed in: oslo/grizzly
   Importance: Undecided => Critical

** Changed in: oslo/grizzly
       Status: New => Fix Released

** Changed in: oslo/grizzly
    Milestone: None => 2013.1

** Changed in: oslo/grizzly
     Assignee: (unassigned) => Davanum Srinivas (DIMS) (dims-v)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1083218

Title:
  oslo changes to logging_context_format_string not compatible with nova

Status in OpenStack Compute (Nova):
  Fix Released
Status in Oslo - a Library of Common OpenStack Code:
  Fix Released
Status in oslo grizzly series:
  Fix Released

Bug description:
  oslo changeset efba20239c1253c3e6ce4a68eed97585a74b8a46 made a change
  to logging_context_format_string to fix a ceilo issue -
  https://bugs.launchpad.net/oslo/+bug/1075095.

  This changed default for logging_context_format_string doesn't work
  for nova, as it assumes the prior keys in it's use of logging in many
  places. Running unit tests with the new logging_context_format_string
  passes, however many many logging stack traces are thrown in the
  process, like:

      test_init_host                                               Traceback (most recent call last):
    File "/usr/lib/python2.7/logging/__init__.py", line 850, in emit
      msg = self.format(record)
    File "/usr/lib/python2.7/logging/__init__.py", line 723, in format
      return fmt.format(record)
    File "/home/sdague/code/openstack/nova/nova/openstack/common/log.py", line 427, in format
      return logging.Formatter.format(self, record)
    File "/usr/lib/python2.7/logging/__init__.py", line 467, in format
      s = self._fmt % record.__dict__
  KeyError: 'user'
  Logged from file vm_utils.py, line 1860

  We need to either revert the oslo change, or come up with a way for
  nova to specify a new default, otherwise nova can't use the oslo
  logging code as is.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1083218/+subscriptions