← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1141750] Re: Unable to extend Nova HostController update method

 

Mark this bug as invalid after discussed with reviewers, because the
controller extension should take care the new parameters can be handled
properly.

** Changed in: nova
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1141750

Title:
  Unable to extend Nova HostController update method

Status in OpenStack Compute (Nova):
  Invalid

Bug description:
  There seems to be a design flaw in the update method where it raises an exception if the maintenance mode and status attributes aren't specified, which makes it impossible to have an API extension that allows the caller to update additional attributes.  None of the other OS API's handle update this way.  It seems alright to check to make sure no extra attributes are specified (since the extension can remove the ones it handles), but these 3 lines need to be removes or commented out:
        #if status is None and maint_mode is None:
        #     explanation = _("'status' or 'maintenance_mode' needed for host update")
        #     raise webob.exc.HTTPBadRequest(explanation=explanation)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1141750/+subscriptions