← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1166377] Re: lbaas db: update_member - need to check the exitance of 'member_db'

 

_get_resource method throws an exception in case member_db is not
found.

** Changed in: quantum
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to quantum.
https://bugs.launchpad.net/bugs/1166377

Title:
  lbaas db: update_member - need to check the exitance of 'member_db'

Status in OpenStack Quantum (virtual network service):
  Invalid

Bug description:
  file: loadbalncer_db.py

  current code:
     def update_member(self, context, id, member):
          v = member['member']
          with context.session.begin(subtransactions=True):
              member_db = self._get_resource(context, Member, id)
              if v:
                  member_db.update(v)

          return self._make_member_dict(member_db)

  should be:

     def update_member(self, context, id, member):
          v = member['member']
          with context.session.begin(subtransactions=True):
              member_db = self._get_resource(context, Member, id)
              if member_db:
                  member_db.update(v)
              else:
                  # TODO: raise exception
          return self._make_member_dict(member_db)

To manage notifications about this bug go to:
https://bugs.launchpad.net/quantum/+bug/1166377/+subscriptions