← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1046758] Re: quantum.plugins.cisco.nova.vifagent.py is broken due to Nova libvirt driver refactoring

 

We removed UCSM/VM-FEX from Grizzly, and it's not in Havana yet either.
Marking this as invalid. Once we add back support for those features, we
will make sure to cover this in that review.

** Changed in: quantum
       Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to quantum.
https://bugs.launchpad.net/bugs/1046758

Title:
  quantum.plugins.cisco.nova.vifagent.py is broken due to Nova libvirt
  driver refactoring

Status in OpenStack Quantum (virtual network service):
  Invalid

Bug description:
  At the start of Folsom development, the libvirt driver was re-written
  to stop using Cheetah templating for XML generation. In the course of
  this the vif.py classes were changed such that they return
  LibvirtConfigGuestInterface object instances, instead of a dictionary
  of template parameters:

    commit 77b7d39cf9a177a5947d3a59461661cde5d3af32
    Author: Daniel P. Berrange <berrange@xxxxxxxxxx>
    Date:   Wed Mar 7 06:57:36 2012 -0500

      Convert libvirt vif classes over to use config API
      
      The classes in the libvirt/vif.py file build up dictionaries
      and partial XML snippets, which are then passed onto Cheetah
      templating for XML generation. Instead of building up
      dictionaries of parameters, return LibvirtConfigGuestInterface
      object instances instead
      
      blueprint libvirt-xml-config-apis
      Change-Id: I4e977225e21219f408dd729ac280dcbfc6b8ba8f
      Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>

  The Quantum Cisco Nova vifagent.py plugin still uses the old approach
  of returning a dictionary of template parameters, and is thus broken
  wrt current Nova libvirt driver requirements.

  Since this breakage has gone unnoticed for so long, it would seem
  there is a clear need to provide unit tests for this class too, while
  fixing the bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/quantum/+bug/1046758/+subscriptions