← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1177205] Re: Instance fault's message has stack trace logs

 

The detail trace logs are for admin, it works as designed, I am
invalidating this defect.

** Changed in: nova
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1177205

Title:
  Instance fault's message has stack trace logs

Status in OpenStack Compute (Nova):
  Invalid

Bug description:
  The instance fault['message'] is displaying exception class, the
  detail message that is thrown from the exception class, and also the
  stack trace logs.

  When user run cli command like "nova show image-name" it will also
  show the stack trace logs as below example. The stack trace logs in
  not necessary here.

  My proposal is that the fault messa

  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  example:                                                                                                                                                                                                                                             |
  | fault                               | {u'message': u'PowerVMImageCreationFailed', u'code': 500, u'details': u'Image creation failed on PowerVM                                                                                                                                         |
  |                                     |   File "/usr/lib/python2.6/site-packages/nova/compute/manager.py", line 816, in _run_instance                                                                                                                                                    |
  |                                     |     set_access_ip=set_access_ip)                                                                                                                                                                                                                 |
  |                                     |   File "/usr/lib/python2.6/site-packages/nova/compute/manager.py", line 1081, in _spawn                                                                                                                                                          |
  |                                     |     LOG.exception(_(\'Instance failed to spawn\'), instance=instance)                                                                                                                                                                            |
  |                                     |   File "/usr/lib64/python2.6/contextlib.py", line 23, in __exit__                                                                                                                                                                                |
  |                                     |     self.gen.next()                                                                                                                                                                                                                              |
  |                                     |   File "/usr/lib/python2.6/site-packages/nova/compute/manager.py", line 1078, in _spawn                                                                                                                                                          |
  |                                     |     block_device_info)                                                                                                                                                                                                                           |
  |                                     |   File "/usr/lib/python2.6/site-packages/nova/virt/powervm/driver.py", line 107, in spawn                                                                                                                                                        |
  |                                     |     self._powervm.spawn(context, instance, image_meta[\'id\'], network_info)                                                                                                                                                                     |
  |                                     |   File "/usr/lib/python2.6/site-packages/nova/virt/powervm/operator.py", line 399, in spawn                                                                                                                                                      |
  |                                     |     LOG.exception(_(\'Error while attempting to \'                                                                                                                                                                                               |
  |                                     |   File "/usr/lib64/python2.6/contextlib.py", line 23, in __exit__                                                                                                                                                                                |
  |                                     |     self.gen.next()                                                                                                                                                                                                                              |
  |                                     |   File "/usr/lib/python2.6/site-packages/nova/virt/powervm/operator.py", line 373, in spawn                                                                                                                                                      |
  |                                     |     _create_image(context, instance, image_id)                                                                                                                                                                                                   |
  |                                     |   File "/usr/lib/python2.6/site-packages/nova/virt/powervm/operator.py", line 354, in _create_image                                                                                                                                              |
  |                                     |     raise exception.PowerVMImageCreationFailed()                                                                                                                                                                                                 |
  |                                     | ', u'created': u'2013-04-16T15:26:36Z'}                                                                                                                                                                                                          |
  -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

  End-user does not need to see the trace log, so my proposal is that the fault's message should only include the exception class 
  name and the detail message as below:
  | fault                               | {u'message': u'PowerVMImageCreationFailed', u'code': 500, u'details': u'Image creation failed on PowerVM

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1177205/+subscriptions