yahoo-eng-team team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

fixed in 0.7.2

** Changed in: cloud-init
       Status: Fix Committed => Fix Released

** Changed in: cloud-init
    Milestone: 0.7.2 => None

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1080985

Title:
  'noblock' setting for resize_rootfs is broken

Status in Init scripts for use on cloud images:
  Fix Released
Status in “cloud-init” package in Ubuntu:
  Fix Released
Status in “cloud-init” source package in Quantal:
  Fix Released

Bug description:
  == Begin SRU Information ==
  [Impact]
   * Users who want to run filesystem resize without blocking first boot are not able to.  This is admittedly small impact, but is clearly broken code.
   
  [TestCase]
   * launch an instance with userdata like:
    #cloud-config
    resize_rootfs: noblock
   * run 'df' in instance, see root filesystem is not resized
   * see /var/log/cloud-init.log showing that resizefs was ignored.

  [Regression Potential]
   * small chance for regression. Previous code checked a small list of values for a boolean value, and did nothing if it was not "true".  The change extends the check to also consider 'noblock'.
  == End SRU Information ==

  resize_rootfs: noblock

  should tell the resize to occur in the background, but it will currently result in:
  Nov 20 04:51:45 ubuntu [CLOUDINIT] cc_resizefs.py[DEBUG]: Skipping module named resizefs, resizing disabled

  The fix is simple, in cloudinit/config/cc_resizefs.py:

      log.warn("resize_root: %s" % resize_root)
      if not util.translate_bool(resize_root) and resize_root not in ("noblock"):
          log.debug("Skipping module named %s, resizing disabled", name)
          return

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1080985/+subscriptions