yahoo-eng-team team mailing list archive

[Chris Behrens <1181412@xxxxxxxxxxxxxxxxxx>]

Sigh.  This appears to be how the python logging module works.

http://docs.python.org/2/library/logging.html

Under logger.debug they have an example use of 'extra'...and then under
it states:

"If you choose to use these attributes in logged messages, you need to
exercise some care. In the above example, for instance, the Formatter
has been set up with a format string which expects ‘clientip’ and ‘user’
in the attribute dictionary of the LogRecord. If these are missing, the
message will not be logged because a string formatting exception will
occur. So in this case, you always need to pass the extra dictionary
with these keys."

:(


** Changed in: nova
       Status: New => Invalid

** Changed in: oslo
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1181412

Title:
  nova unit tests pass with LOG.*() calls that should generate KeyError

Status in OpenStack Compute (Nova):
  Invalid
Status in Oslo - a Library of Common OpenStack Code:
  Invalid

Bug description:
  I just found a broken LOG.debug() message in the cells/scheduler which
  references a non-existant keyword arg.  Tests run fine.  I've inserted
  a different completely bogus LOG.debug() message and it also passes.
  It seems that LOG.debug()s are being turned into no-ops.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1181412/+subscriptions