yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: keystone
       Status: Fix Committed => Fix Released

** Changed in: keystone
    Milestone: None => havana-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1166182

Title:
  grizzly sample_data.sh ignores password variables

Status in OpenStack Identity (Keystone):
  Fix Released
Status in Keystone grizzly series:
  Fix Committed

Bug description:
  The change merged as part of bug #1073291 removes useful functionality
  - pre grizzly, it was possible to pass in a specific password via the
  ADMIN_PASSWORD and SERVICE_PASSWORD variables, but these variables are
  now ignored.

  # Please set these, they are ONLY SAMPLE PASSWORDS!
  ADMIN_PASSWORD=${ADMIN_PASSWORD:-secrete}
  if [[ "$ADMIN_PASSWORD" == "secrete" ]]; then
      echo "The default admin password has been detected.  Please consider"
      echo "setting an actual password in environment variable ADMIN_PASSWORD"
  fi
  SERVICE_PASSWORD=${SERVICE_PASSWORD:-$ADMIN_PASSWORD}
  if [[ "$SERVICE_PASSWORD" == "$ADMIN_PASSWORD" ]]; then
      echo "The default service password has been detected.  Please consider"
      echo "setting an actual password in environment variable SERVICE_PASSWORD"
  fi

  
  For some reason, this code was completely removed from sample_data.sh, instead of just aligning the values with the docs.

  This silently breaks any scripts which specify a password, which is
  pretty confusing when moving from Folsom until you realize what is
  going wrong (e.g the heat tools/openstack script :
  https://github.com/openstack/heat/blob/master/tools/openstack#L238)

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1166182/+subscriptions