yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: glance
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1163722

Title:
  Monkey patching done after logging

Status in OpenStack Image Registry and Delivery Service (Glance):
  Fix Released

Bug description:
  It seems like monkey patching in glance is done after certain modules
  are already imported and setup. This is due to the monkey patching
  being done in
  https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L208,
  This can cause problems, one example is the logging module which is
  setup before this code is executed, and potentially it can be setup
  with non-monkey-patched modules, which means modules that will block.
  So say you have a custom logger that does more than the basic logger
  that comes with python, its usage in glance will cause blocking calls
  to occur.

  Likely the order of monkey patching needs to be reworked??
  Looking at nova code they monkey patch very early, instead of later like in glance.
  Maybe there are reasons for this in glance?

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1163722/+subscriptions