yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => havana-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1177635

Title:
  code logical error exists in vmwareapi vif.py

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  nova/virt/vmwareapi/vif.py
   
  60         if network_ref is None:
   61         # Create a port group on the vSwitch associated with the
   62         # vlan_interface corresponding physical network adapter on the ESX
   63         # host.
   64             network_util.create_port_group(session, bridge,
   65                                        vswitch_associated, vlan_num,
   66                                        cluster)
   67         else:
   68             # Get the vlan id and vswitch corresponding to the port group
   69             _get_pg_info = network_util.get_vlanid_and_vswitch_for_portgroup
   70             pg_vlanid, pg_vswitch = _get_pg_info(session, bridge, cluster)
   71 
   72         # Check if the vswitch associated is proper
   73         if pg_vswitch != vswitch_associated:
   74             raise exception.InvalidVLANPortGroup(
   75                 bridge=bridge, expected=vswitch_associated,
   76                 actual=pg_vswitch)
   77 

  the check for  pg_vlanid, pg_vswitch  logic code have wrong indent ,
  cause a  referenced before assignment error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1177635/+subscriptions