← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1171376] Re: remove unecessary function argument in vmwareapi

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => havana-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1171376

Title:
  remove unecessary function argument  in vmwareapi

Status in OpenStack Compute (Nova):
  Fix Released
Status in OpenStack Compute (nova) grizzly series:
  Fix Released

Bug description:
  nova/virt/vmwareapi/vif.py

   37 def ensure_vlan_bridge(self, session, vif, cluster=None):
   38     """Create a vlan and bridge unless they already exist."""
   39     vlan_num = vif['network'].get_meta('vlan')
   40     bridge = vif['network']['bridge']
   41     vlan_interface = CONF.vmwareapi_vlan_interface
   42 
   43     # Check if the vlan_interface physical network adapter exists on the
   44     # host.

  the 'self' argument is unnecessary and when invoked, cause parameters
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1171376/+subscriptions