yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: quantum
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to quantum.
https://bugs.launchpad.net/bugs/1173131

Title:
  SQLAlchemy Query.all() can't raise NoResultFound exception

Status in OpenStack Quantum (virtual network service):
  Fix Released

Bug description:
  all() returns an empty list when no result is found, so there is no
  sense to except NoResultFound and return an empty list like the
  following code does:

          try:
              dns_qry = context.session.query(models_v2.DNSNameServer)
              return dns_qry.filter_by(subnet_id=subnet_id).all()
          except exc.NoResultFound:
              return []

  We have a lot of such cases in our code which should be fixed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/quantum/+bug/1173131/+subscriptions