← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1182117] Re: live migration error notification do not include vm uuid

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => havana-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1182117

Title:
  live migration error notification do not include vm uuid

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  Take a look at scheduler/manager.py:live_migrate

  def live_migration(self, context, instance, dest,
                         block_migration, disk_over_commit):
          try:
              return self.driver.schedule_live_migration(
                  context, instance, dest,
                  block_migration, disk_over_commit)
          except (exception.NoValidHost,
                  exception.ComputeServiceUnavailable,
                  exception.InvalidHypervisorType,
                  exception.UnableToMigrateToSelf,
                  exception.DestinationHypervisorTooOld,
                  exception.InvalidLocalStorage,
                  exception.InvalidSharedStorage,
                  exception.MigrationPreCheckError) as ex:
              request_spec = {'instance_properties': {
                  'uuid': instance['uuid'], },
              }
              with excutils.save_and_reraise_exception():
                  self._set_vm_state_and_notify('live_migration',
                              dict(vm_state=instance['vm_state'],
                                   task_state=None,
                                   expected_task_state=task_states.MIGRATING,),
                                                context, ex, request_spec)
          except Exception as ex:
              with excutils.save_and_reraise_exception():
                  self._set_vm_state_and_notify('live_migration',
                                               {'vm_state': vm_states.ERROR},
                                               context, ex, {}) <<<< request_spec is {}, this will cause the notification do not include vm uuid and  the receiver do not know which VM goes to ERROR state

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1182117/+subscriptions