← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1156227] Re: missing UC on virtual_interfaces.address in sqlite

 

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1156227

Title:
  missing UC on virtual_interfaces.address in sqlite

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  This affects only sqlite: (So probably it is not so important)

  In sqlite we are not able to drop Constraints so we are not able to drop columns with constraints.
  And deleted columns have type of Boolean which in sqlite has constraint (in (0,1))

  So only way that I found was to use shadow tables. (Create new table
  with correct type of deleted) and copy data from old table to new..
  and then drop old table and rename new to old name.

  Unfortunately there is probably one more bug in sqlalchemy, for some reason there is no uC in table's constraints.
  So we lost all UC in sqlite that ware used.

  There is only one table with such problem virtual_interfaces.address
  (Currently I am working on tests)

  To fix this bug I should add one more db.migration.

  I think that this is not so important and could wait for Havana. How
  do you think?

  By the way, I think that we should remove UC on address and make it on
  (address, deleted). Then we will be able to use soft_delete instead of delete. So probably it is better to fix it in Havana-1.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1156227/+subscriptions