← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1178738] Re: s3 middleware depends on swift

 

** Changed in: keystone
       Status: Fix Committed => Fix Released

** Changed in: keystone
    Milestone: None => havana-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1178738

Title:
  s3 middleware depends on swift

Status in OpenStack Identity (Keystone):
  Fix Released

Bug description:
  The s3 middleware imports:

  from swift.common import utils as swift_utils

  
  This is used to initiate the logging:

  https://github.com/openstack/keystone/blob/master/keystone/middleware/s3_token.py#L57
   self.logger = swift_utils.get_logger(conf, log_route='s3token')

  
  howerver, python has a standard logging framework, and we should not be bypassing that.  It is up to the project that imports the middleware to set up logging properly, not up to the middleware to conform to multiple projects.

  THis requires two things:  1, on the swift side, set up the custom
  logging using the standard python mechanism, and 2 getting this
  middleware to use the python  logging framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1178738/+subscriptions