yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1179526

Title:
  source_lang in Horizon repo is overwritten by Transifex

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  I noticed source_lang in Horizon repo is overwritten by other translations on Transifex.
  There are two problems and these two seem to be related to each other.

  (1) While Source language in the Horizon repository is 'en' (defined by LANGUAGE_CODE in openstack_dashboard/settings.py),
  source_lang in Transifex is 'en_US'. As a result, transifex client cannot find the source language.

  (2) In addition Horizon on Transifex has 'en' as translation. The
  second situation leads to overwriting the source language in the repo
  (openstack_dashboard/locale/en or horizon/locale/en) with 'en'
  language resource in Transifex when executing 'tx pull -f -a' to
  download translation PO files.

  A translation may contain wrong translation string, so we should not
  overwrite the source language by translations.

  
  Issue (1) can usually be fixed by language mapping or source_file in Transifex client configuration
    source_file = horizon/locale/en/LC_MESSAGES/django.po

  issue (2) complicates the situation. The problem is which language we
  should map 'en' on Transifex into.

  The best way is to remove the language 'en' on Transifex or switch the source language on Transifex from 'en_US' to 'en'.
  But I am afraid changing the source language is not easy. I don't know why 'en' language in Horizon was created.

  The alternative is to map 'en' on Transifex to a dummy language in Horizon repo.
  Though it is an adhoc fix, I believe it is important to avoid overwriting 'en' locale in Horizon repo by running 'tx pull'.
  (It is not good to do this by manual)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1179526/+subscriptions