← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1208628] Re: Logic in add_host_to_aggregate() is incorrect.

 

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1208628

Title:
  Logic in add_host_to_aggregate() is incorrect.

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The logic to check if the host being added to an availability zone is
  already a member of an availability zone in add_host_to_aggregate()
  added in: I788782a9f21ec2672551f75123753175bb268586 does not work
  correctly. The db query to get the availability_zone key from the
  aggregate metadata returns a set of values. However the pop() call
  only returns the last entry in the set. Additionally, the pop() would
  not work if db call returned nothing for the az key.

  Also there was no protection against the availability zone key not
  being in the database. So if if an aggregate was created without an
  availability zone this check would raise a KeyError when you tried to
  add a host to it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1208628/+subscriptions