← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1219440] Re: dpd timeout == dpd should be 400

 

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1219440

Title:
  dpd timeout == dpd should be 400

Status in OpenStack Neutron (virtual network service):
  Fix Released
Status in Python client library for Neutron:
  Invalid

Bug description:
  During the CLI review https://review.openstack.org/#/c/43837, I
  noticed there is a confusion on whether timeout == interval is valid
  or not.

  I checked VPNaaS document (in review), Neutron VPNaaS server code. The summary is as follows:
  - Neutron VPN DB code: timeout == interval is accepted
  - Neutron VPN doc: timeout == interval is invalid
  - Neutron VPN CLI help: timeout == interval is invalid

  Which is the expected behavior?

  Since there is a confusion, I proposed a patch which removes the test
  dpd_timeout_less_than_interval from  create_ipsec_site_connection and
  letting the server validate the relationship between timeout and
  interval. The validation for the relation between timeout and interval
  can be added again in the future (if needed).

  I don't know the exact reason VPN CLI and VPN code in the server do
  the duplicated validation. Other resources (such as neutron core
  resources, LBaaS, FWaaS) do not.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1219440/+subscriptions