yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => havana-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1212017

Title:
      def _test_network_api(self, method, rpc_method, **kwargs) is
  broken

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  nova/tests/network/test_rpcapi.py

  for arg, expected_arg in zip(self.fake_args, expected_args):
              try:
                  self.assertEqual(arg, expected_arg)
              except AssertionError:
                  # actual_args may contain optional args, like the one that
                  # have default values; therefore if arg and excepted_arg
                  # do not match verify at least that the required ones do
                  if isinstance(arg, dict) and isinstance(expected_arg, dict):
                      actual_args = arg.get('args')
                      required_args = expected_arg.get('args')
                      if actual_args and required_args:
                          self.assertThat(required_args,
                                          matchers.IsSubDictOf(actual_args))

  Note the missing else: clause on the 'if isinstance(arg, dict) and
  ...' case.

  When arg != expected_arg and either of them is not a dict, the
  exception is swallowed, invalidating tests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1212017/+subscriptions