yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => havana-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1206993

Title:
  redundant _create_instance method in test_compute

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  nova.tests.compute.test_compute.BaseTestCase has a
  _create_fake_instance and _create_instance method which do the same
  thing, and _create_instance simply calls _create_fake_instance().
  Furthermore, the docstring on _create_instance is wrong, it says it
  returns the UUID of the instance when it actually returns the instance
  reference returned from sqlalchemy.  This should be cleaned up so that
  the tests are only using _create_fake_instance.

  https://github.com/openstack/nova/blob/master/nova/tests/compute/test_compute.py#L252

  https://github.com/openstack/nova/blob/master/nova/tests/compute/test_compute.py#L295

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1206993/+subscriptions