← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1191923] Re: Comments in requirements.txt are not parsed

 

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1191923

Title:
  Comments in requirements.txt are not parsed

Status in Designate:
  Fix Released
Status in Orchestration API (Heat):
  Fix Released
Status in OpenStack Neutron (virtual network service):
  Fix Released
Status in Python Build Reasonableness:
  Fix Released

Bug description:
  I've ran python setup.py install in the latest quantum and pbr choked
  on parsing a line leading with a #:

  (venv)amir@devbox:~/bug/quantum$ python setup.py install
  running install
  Traceback (most recent call last):
    File "setup.py", line 21, in <module>
      d2to1=True)
    File "/usr/lib/python2.7/distutils/core.py", line 152, in setup
      dist.run_commands()
    File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
      self.run_command(cmd)
    File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
      cmd_obj.run()
    File "/home/amir/bug/quantum/pbr-0.5.17-py2.7.egg/pbr/packaging.py", line 310, in run
      _pip_install(links, self.distribution.install_requires, self.root)
    File "/home/amir/bug/quantum/pbr-0.5.17-py2.7.egg/pbr/packaging.py", line 95, in _pip_install
      " ".join(_wrap_in_quotes(_missing_requires(requires)))),
    File "/home/amir/bug/quantum/pbr-0.5.17-py2.7.egg/pbr/packaging.py", line 83, in _missing_requires
      pkg_resources.Requirement.parse(r))]
    File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2598, in parse
      raise ValueError("No requirements found", s)
  ValueError: ('No requirements found', '# Cisco plugin dependencies')

To manage notifications about this bug go to:
https://bugs.launchpad.net/designate/+bug/1191923/+subscriptions