yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1206620

Title:
  Minor fixes for comments in merged firewall API patch

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:

  
  neutron/db/firewall/firewall_db.py

  222	    def _get_port_range_from_min_max_ports(self, min_port, max_port):
  223	        if not min_port:
  224	            return None
  225	        if min_port == max_port:
  226	            return str(min_port)
  227	        else:
  228	            return str(min_port) + ':' + str(max_port)
  mark mcclain		7:48 AM
  In a follow up patch..
  return '%d:%d' % (min_port, max_port)
  Reply ...

  
  211	    def _get_min_max_ports_from_range(self, port_range):
  212	        if not port_range:
  213	            return [None, None]
  214	        ports = port_range.split(':')
  Paul Michali		4:32 AM
  You could do...
  min_port, sep, max_port = port_range.partition(":")
  if not max_port:
      max_port = min_port
  return [int(min_port), int(max_port)]

  neutron/extensions/firewall.py
  class FirewallRuleInfoMissing(qexception.InvalidInput):
  88	    message = _("Missing rule info argument for insert/remove "
  89	                "rule opertaion.")
  Armando Migliaccio		10:17 AM
  grammar nit.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1206620/+subscriptions