← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1180783] Re: Clean up code in Cisco Nexus plugin's _get_all_segmentation_ids

 

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1180783

Title:
  Clean up code in Cisco Nexus plugin's _get_all_segmentation_ids

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  The implementation of the _get_all_segmentation_ids method in the Cisco Nexus plugin's virt_phy_sw_v2 module can be cleaned up.  The six lines in the current implementation can be replaced with a single line.  This was brought up in the review for blueprint cisco-plugin-exception-handling.  The comment in that review explains:
  	Unrelated to this change, but can we file a bug to clean this up? Replace 170-175 with:
               return ','.join(str(v_id) for v_id in cdb.get_ovs_vlans() if int(v_id) > 0)
  Also, in the __init__ method for VirtualPhysicalSwitchModelV2 class in the same module, the '\n' can be removed from this line:
          LOG.debug(_("Loaded device plugin %s\n"),

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1180783/+subscriptions