yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1222574] Re: Test for list_users in test_backend is not safe

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Wed, 02 Oct 2013 11:34:26 -0000
Reply-to: Bug 1222574 <1222574@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: keystone
       Status: Fix Committed => Fix Released

** Changed in: keystone
    Milestone: None => havana-rc1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1222574

Title:
  Test for list_users in test_backend is not safe

Status in OpenStack Identity (Keystone):
  Fix Released

Bug description:
  The test for list_users in test_backend is written as:

      def test_list_users(self):
          users = self.identity_api.list_users()
          for test_user in default_fixtures.USERS:
              self.assertTrue(x for x in users if x['id'] == test_user['id'])

  This is not safe.  You can show this by, for instance, setting users =
  [] instead of the correct result from self.identity_api.list_users()
  and no asset is raised

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1222574/+subscriptions