yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1221360] Re: PCI Device object improperly ignores missing db_object fields

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Thu, 03 Oct 2013 07:43:44 -0000
Reply-to: Bug 1221360 <1221360@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1221360

Title:
  PCI Device object improperly ignores missing db_object fields

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  In PCIDevice._from_db_object():

    pci_device[key] = db_dev.get(key)

  This makes the method ignore missing database object keys, which
  prevents the strict typechecking from doing it's job, and differs from
  every other object model currently in the tree. As a result, non-
  nullable attributes such as dev_type are string-converted to "None" in
  the object, which is definitely not the intent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1221360/+subscriptions