yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1229508] Re: nec plugin: packetfilter table network_id nullable should be False in folsom_initial db migration

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Thu, 03 Oct 2013 08:03:03 -0000
Reply-to: Bug 1229508 <1229508@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1229508

Title:
  nec plugin: packetfilter table network_id nullable should be False in
  folsom_initial db migration

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  From the initial commit of NEC plugin, network_id of packetfilters table is nullable=False [1],
  but in folsom_initial db migration script nullable is set to True.

  nullable=False is just a more strict constraint than nullable=True,
  so NEC plugin works but it is better to be fixed in the migration.

  I will add the migration to network_id to nullable=False both upgrade and downgrade
  to make sure nullable=False in any revision.

  [1]
  https://github.com/openstack/neutron/blob/stable/folsom/quantum/plugins/nec/db/models.py#L53

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1229508/+subscriptions