← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1227080] Re: deleted_at value in notification messages is wrong

 

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1227080

Title:
  deleted_at value in notification messages is wrong

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The deleted_at value in notification messages is set from the
  terminated_at  value in the instance record.

  Note that there is this comment in the notification code:

          # Nova's deleted vs terminated instance terminology is confusing,
          # this should be when the instance was deleted (i.e. terminated_at),
          # not when the db record was deleted. (mdragon)
          deleted_at=null_safe_isotime(instance_ref.get('terminated_at')),

  While I can see that there might be some confusion between
  terminated_at and deleted_at - mapping from one name to the other in
  the notification message doesn't seem like a great way to resolve it.
  Surely it would be better to keep the names consistent and include
  both values in the message - so that the receiver can decide which one
  they want to use.

  This current remapping just enforces one view of difference (or not)
  between a terminated and a deleted instance

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1227080/+subscriptions