yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1225614] Re: Using webob constants instead of hard coded HTTP status codes

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Thu, 03 Oct 2013 08:02:24 -0000
Reply-to: Bug 1225614 <1225614@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1225614

Title:
  Using webob constants instead of hard coded HTTP status codes

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  In test_db_plugin.py , hard coded error codes are used explicitly
  instead of using predefined webob codes.

  Example:
      https://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_db_plugin.py#L777
      This unit test is dealing a lot with HTTP return codes.
      The number 404 is used here explicitly  (line #780).

  These constants are already defined here: ./usr/local/lib/python2.7/dist-packages/webob/exc.py
  Example: 404 is webob.exc.HTTPNotFound.code

  It is basically search and replace task with minimal risk.
  All hardcoded error codes should be replaced by webob constants

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1225614/+subscriptions