yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1220541] Re: Misuse of assertTrue in virt test scripts

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Thu, 03 Oct 2013 08:00:42 -0000
Reply-to: Bug 1220541 <1220541@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1220541

Title:
  Misuse of assertTrue in virt test scripts

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  nova/tests/virt/libvirt/test_imagecache.py
  -        self.assertTrue(len(image_cache_manager.corrupt_base_files), 0)

  nova/tests/virt/xenapi/test_xenapi.py
  -        self.assertTrue(api_calls.get('VM.pool_migrate'), expected)
  -        self.assertTrue(instance['vm_state'], vm_states.ACTIVE)
  -        self.assertTrue(instance['task_state'], task_states.MIGRATING)

  Should use assertEquals instead of assertTrue

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1220541/+subscriptions