← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1220522] Re: Misuse of assertTrue in Cells test scripts

 

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1220522

Title:
  Misuse of assertTrue in Cells test scripts

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  In nova/tests/cells/test_cells_messaging.py,

  line 365: self.assertTrue(response.value_or_raise(),
  'our_fake_response')

  Should be self.assertEqual(...)

  and

  In nova/tests/cells/test_cells_utils.py

  line 52: self.assertTrue(len([x for x in instances]), 3)
  line 60: self.assertTrue(len([x for x in instances]), 3)
  line 68: self.assertTrue(len([x for x in instances]), 3)
  line 78: self.assertTrue(len([x for x in instances]), 3)

  All Should be self.assertEqual(...)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1220522/+subscriptions