yahoo-eng-team team mailing list archive

[OpenStack Infra <1237102@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/51076
Committed: http://github.com/openstack/nova/commit/157249a69f5e99a94df36f00adb139c353cac25e
Submitter: Jenkins
Branch:    milestone-proposed

commit 157249a69f5e99a94df36f00adb139c353cac25e
Author: Dan Smith <dansmith@xxxxxxxxxx>
Date:   Mon Oct 7 13:02:09 2013 -0700

    Fix conductor's object change detection
    
    Conductor was doing a copy.copy() on the inbound object to later
    detect changes that should be sent back to the caller. This does not
    copy things like Instance.system_metadata and thus is incapable of
    properly detecting changes that should be tracked.
    
    This patch makes conductor use obj_clone(), and imports Chris
    Behrens' __deepcopy__ fix for objects so that deepcopy works.
    
    Closes-bug: #1237102
    Change-Id: I46ae8b0694dc31a90c1a5cdf76757d877877f072
    (cherry picked from commit 73b3bf91df00059c69dc1dd81e4554ec24c647b1)


** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1237102

Title:
  Conductor does not properly copy objects during change tracking

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The conductor object_action() method does a shallow copy of the
  instance in order to do change tracking after the method is called.
  This is not sufficient as complex types like dicts and lists will not
  be copied and then the change detection logic will think those fields
  have not changed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1237102/+subscriptions