← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1212082] Re: Improve the sql query performance of tag querying

 

** Changed in: glance
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1212082

Title:
  Improve the sql query performance of tag querying

Status in OpenStack Image Registry and Delivery Service (Glance):
  Invalid

Bug description:
  After review the method "image_tag_get_all" of <sqlalchemy>/api.py,
  we're trying to order the list by created_at. However,  it's
  meaningless from the end-user perspective. Since there is no priority
  for tags and we can't say one tag is more useful/important than
  another one. And even worse, it may introduce some performance issue.

  =============================================================
  mysql> explain SELECT image_tags.created_at AS image_tags_created_at, image_tags.updated_at AS image_tags_updated_at, image_tags.deleted_at AS image_tags_deleted_at, image_tags.deleted AS image_tags_deleted, image_tags.id AS image_tags_id, image_tags.image_id AS image_tags_image_id, image_tags.value AS image_tags_value FROM image_tags WHERE image_tags.image_id = 'c67d1ff2-c5c7-411b-9bf0-2c723e746434' AND image_tags.deleted = 0 ORDER BY image_tags.created_at ASC;
  +----+-------------+------------+------+---------------------------------------------------------+------------------------+---------+-------+------+-----------------------------+
  | id | select_type | table      | type | possible_keys                                           | key                    | key_len | ref   | rows | Extra                       |
  +----+-------------+------------+------+---------------------------------------------------------+------------------------+---------+-------+------+-----------------------------+
  |  1 | SIMPLE      | image_tags | ref  | ix_image_tags_image_id,ix_image_tags_image_id_tag_value | ix_image_tags_image_id | 110     | const |    2 | Using where; Using filesort |
  +----+-------------+------------+------+---------------------------------------------------------+------------------------+---------+-------+------+-----------------------------+
  1 row in set (0.01 sec)

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1212082/+subscriptions