← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1241952] Re: Alembic migration: "DROP": syntax error u'ALTER TABLE ipallocations DROP COLUMN expiration' ()

 

I remember there were attempts to fix migrations for sqlite, but due to lack of support for ALTER statements in sqlite, those attempts could complicate migrations a lot.
So I'm marking the bug as 'Won't fix'

** Changed in: neutron
       Status: New => Won't Fix

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1241952

Title:
  Alembic migration: "DROP": syntax error u'ALTER TABLE ipallocations
  DROP COLUMN expiration' ()

Status in OpenStack Neutron (virtual network service):
  Won't Fix

Bug description:
  After applying this patch: https://review.openstack.org/#/c/52636
  (including the 'True' instead of True which I wrote in my comment),
  then another error appears:

  INFO  [alembic.migration] Running upgrade c88b6b5fea3 -> f9263d6df56
  Traceback (most recent call last):
    File "/usr/bin/neutron-db-manage", line 10, in <module>
      sys.exit(main())
    File "/usr/lib/python2.7/dist-packages/neutron/db/migration/cli.py", line 143, in main
      CONF.command.func(config, CONF.command.name)
    File "/usr/lib/python2.7/dist-packages/neutron/db/migration/cli.py", line 80, in do_upgrade_downgrade
      do_alembic_command(config, cmd, revision, sql=CONF.command.sql)
    File "/usr/lib/python2.7/dist-packages/neutron/db/migration/cli.py", line 59, in do_alembic_command
      getattr(alembic_command, cmd)(config, *args, **kwargs)
    File "/usr/lib/python2.7/dist-packages/alembic/command.py", line 124, in upgrade
      script.run_env()
    File "/usr/lib/python2.7/dist-packages/alembic/script.py", line 191, in run_env
      util.load_python_file(self.dir, 'env.py')
    File "/usr/lib/python2.7/dist-packages/alembic/util.py", line 186, in load_python_file
      module = imp.load_source(module_id, path, open(path, 'rb'))
    File "/usr/lib/python2.7/dist-packages/neutron/db/migration/alembic_migrations/env.py", line 105, in <module>
      run_migrations_online()
    File "/usr/lib/python2.7/dist-packages/neutron/db/migration/alembic_migrations/env.py", line 89, in run_migrations_online
      options=build_options())
    File "<string>", line 7, in run_migrations
    File "/usr/lib/python2.7/dist-packages/alembic/environment.py", line 494, in run_migrations
      self.get_context().run_migrations(**kw)
    File "/usr/lib/python2.7/dist-packages/alembic/migration.py", line 211, in run_migrations
      change(**kw)
    File "/usr/lib/python2.7/dist-packages/neutron/db/migration/alembic_migrations/versions/f9263d6df56_remove_dhcp_lease.py", line 41, in upgrade
      op.drop_column('ipallocations', u'expiration')
    File "<string>", line 7, in drop_column
    File "/usr/lib/python2.7/dist-packages/alembic/operations.py", line 380, in drop_column
      **kw
    File "/usr/lib/python2.7/dist-packages/alembic/ddl/impl.py", line 129, in drop_column
      self._exec(base.DropColumn(table_name, column, schema=schema))
    File "/usr/lib/python2.7/dist-packages/alembic/ddl/impl.py", line 75, in _exec
      conn.execute(construct, *multiparams, **params)
    File "/usr/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1449, in execute
      params)
    File "/usr/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1542, in _execute_ddl
      compiled
    File "/usr/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1698, in _execute_context
      context)
    File "/usr/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1691, in _execute_context
      context)
    File "/usr/lib/python2.7/dist-packages/sqlalchemy/engine/default.py", line 331, in do_execute
      cursor.execute(statement, parameters)
  sqlalchemy.exc.OperationalError: (OperationalError) near "DROP": syntax error u'ALTER TABLE ipallocations DROP COLUMN expiration' ()

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1241952/+subscriptions