yahoo-eng-team team mailing list archive

["Davanum Srinivas \(DIMS\)" <davanum@xxxxxxxxx>]

No tools/run_pep8.sh any more :)

** Changed in: nova
       Status: Triaged => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1163037

Title:
  run_pep8.sh fails with N302 errors in clean env

Status in OpenStack Compute (Nova):
  Invalid

Bug description:
  My builds of the nova are failing apparently due to run_pep8.sh
  reporting N302 errors.

  $ git rev-parse HEAD
  b0998792222bd3aede65feeb32d1c2d6e6f8080b

  $ tools/run_pep8.sh
  199 passed and 0 failed.
  Test passed.
  3 imports missing in this test environment
  ./nova/exception.py:34:1: N302  import only modules.'from nova import safe_utils' does not import a module
  ./nova/tests/test_safeutils.py:17:1: N302  import only modules.'from nova import safe_utils' does not import a module
  ./nova/compute/manager.py:71:1: N302  import only modules.'from nova import safe_utils' does not import a module
  9 imports missing in this test environment
  $ echo $?
  1

  It looks like the above all came from the same commit (1d5154ed):

  $ git blame -L34,34 nova/exception.py
  1d5154ed (Sandy Walsh 2013-02-21 10:21:39 -0400 34) from nova import safe_utils
  $ git blame -L17,17 nova/tests/test_safeutils.py
  1d5154ed (Sandy Walsh 2013-02-21 10:21:39 -0400 17) from nova import safe_utils
  $ git blame -L71,71 nova/compute/manager.py
  1d5154ed (Sandy Walsh 2013-02-21 10:21:39 -0400 71) from nova import safe_utils

  The Gerrit review for the above is here:
  https://review.openstack.org/#/c/23609/

  It looks as though it passed run_pep8.sh and has continued to do so in subsequent jenkins.openstack.org builds:
  http://logs.openstack.org/23609/1/gate/gate-nova-pep8/22345/console.html.gz

  Is it possible something is masking the error or causing failures in
  run_pep8.sh not to trigger a failure of the upstream build?

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1163037/+subscriptions