yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1246831] Re: Creating trust with invalid expires_at causes 500 error

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Wed, 04 Dec 2013 09:29:29 -0000
Reply-to: Bug 1246831 <1246831@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: keystone
       Status: Fix Committed => Fix Released

** Changed in: keystone
    Milestone: None => icehouse-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1246831

Title:
  Creating trust with invalid expires_at causes 500 error

Status in OpenStack Identity (Keystone):
  Fix Released

Bug description:
  If you attempt to create a trust with an invalid expires_at field
  (something which can't be parsed by timeutils.parse_isotime resulting
  in a ValueError), you get a 500 response

  https://github.com/openstack/keystone/blob/master/keystone/trust/controllers.py#L172

  2013-10-31 18:12:25.365 4359 ERROR keystone.common.wsgi [-] Unable to parse date string u'bad.123Z'
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi Traceback (most recent call last):
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi   File "/opt/stack/keystone/keystone/common/wsgi.py", line 238, in __call__
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi     result = method(context, **params)
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi   File "/opt/stack/keystone/keystone/common/controller.py", line 158, in inner
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi     return f(self, context, *args, **kwargs)
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi   File "/opt/stack/keystone/keystone/trust/controllers.py", line 174, in create_trust
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi     (trust['expires_at']))
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi   File "/opt/stack/keystone/keystone/openstack/common/timeutils.py", line 52, in parse_isotime
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi     raise ValueError(unicode(e))
  2013-10-31 18:12:25.365 4359 TRACE keystone.common.wsgi ValueError: Unable to parse date string u'bad.123Z'

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1246831/+subscriptions