yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1236681

Title:
  ObjectDetailView downloads the entire object

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  This view uses the swift_get_object method, which gets the entire
  object, including the data. It should be using HEAD instead. The
  object size is in the content-length header.

  openstack_dashboard/dashboards/project/containers/views.py:

  251 class ObjectDetailView(forms.ModalFormMixin, generic.TemplateView):
  252     template_name = 'project/containers/object_detail.html'
  253 
  254     def get_object(self):
  255         if not hasattr(self, "_object"):
  256             try:
  257                 self._object = api.swift.swift_get_object(
  258                     self.request,
  259                     self.kwargs["container_name"],
  260                     self.kwargs["object_path"])
  261                 print self._object.data
  262             except Exception:
  263                 redirect = reverse("horizon:project:containers:index")
  264                 exceptions.handle(self.request,
  265                                   _('Unable to retrieve details.'),
  266                                   redirect=redirect)
  267         return self._object

  
  openstack_dashboard/api/swift.py:

  253 def swift_get_object(request, container_name, object_name):
  254     headers, data = swift_api(request).get_object(container_name, object_name)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1236681/+subscriptions