yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1226698

Title:
  flavor pagination incorrectly uses id rather than flavorid

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The "ID" in flavor-list response is really instance_types.flavorid in database.  When using the marker, it use instance_types.id field. The test pass as long as instance_types.id begin with 1 and it is sequential. If it does not begin with 1 or if it does not match instance_types.flavorid, the test fail with following error:                                                                          
                                                                                  
  '''                                                                             
  Traceback (most recent call last):                                              
    File "/Volumes/apple/openstack/tempest/tempest/api/compute/flavors/test_flavors.py", line 91, in test_list_flavors_detailed_using_marker                             
      resp, flavors = self.client.list_flavors_with_detail(params)                
    File "/Volumes/apple/openstack/tempest/tempest/services/compute/json/flavors_client.py", line 45, in list_flavors_with_detail                                            
      resp, body = self.get(url)                                                  
    File "/Volumes/apple/openstack/tempest/tempest/common/rest_client.py", line 263, in get
      return self.request('GET', url, headers)                                    
    File "/Volumes/apple/openstack/tempest/tempest/common/rest_client.py", line 394, in request
      resp, resp_body)                                                            
    File "/Volumes/apple/openstack/tempest/tempest/common/rest_client.py", line 439, in _error_checker
      raise exceptions.NotFound(resp_body)                                        
  NotFound: Object not found                                                      
  Details: {"itemNotFound": {"message": "The resource could not be found.", "code": 404}}
                                                                                  
  ======================================================================          
  FAIL: tempest.api.compute.flavors.test_flavors.FlavorsTestJSON.test_list_flavors_using_marker[gate]
  '''                                                                             
                                                                                  
  Really, it should use flavorid for marker.  The flavor_get_all() method in nova.db.sqlalchemy.api should be fixed to use flavorid=marker in filter, as follows:                                                                        
  -                    filter_by(id=marker).\                                     
  +                    filter_by(flavorid=marker).\

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1226698/+subscriptions