yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1237679

Title:
  Fix useless vmware pause/unpause test methods

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  The vmwareapi test class that tests the VMwareESXDriver has a
  test_pause and test_unpause method that simply passes:

  https://github.com/openstack/nova/blob/master/nova/tests/virt/vmwareapi/test_vmwareapi.py#L632

  https://github.com/openstack/nova/blob/master/nova/tests/virt/vmwareapi/test_vmwareapi.py#L635

  Those APIs aren't supported by the VMwareESXDriver so they should
  actually test that the code raises NotImplementedError.

  https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L957

  https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L961

  I think the test class was doing a pass for the esx driver because the
  test class for the vcdriver extends the esx driver test class, but the
  method isn't any different for the vcdriver test class so it should
  just assert it raises NotImplementedError either way.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1237679/+subscriptions