yahoo-eng-team team mailing list archive

Thread
Date
[Bug 1244829] Re: destroy() method broken on Docker virt driver

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Wed, 04 Dec 2013 10:36:47 -0000
Reply-to: Bug 1244829 <1244829@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx
** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1244829

Title:
  destroy() method broken on Docker virt driver

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  Just saw that virt drivers now take an extra arg "context" on the
  destroy method. For some reason, it has not been added to the docker
  driver... The destroy method with the driver enabled currently fails
  with the following error:

  2013-10-25 23:03:20.764 ERROR nova.openstack.common.rpc.amqp [req-75ff872a-fd4d-4b63-a587-93b9fd3ede4b demo demo] Exception during message handling
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp Traceback (most recent call last):
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/openstack/common/rpc/amqp.py", line 461, in _process_data
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     **args)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/openstack/common/rpc/dispatcher.py", line 172, in dispatch
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     result = getattr(proxyobj, method)(ctxt, **kwargs)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 353, in decorated_function
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     return function(self, context, *args, **kwargs)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/exception.py", line 90, in wrapped
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     payload)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/exception.py", line 73, in wrapped
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     return f(self, context, *args, **kw)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 243, in decorated_function
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     pass
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 229, in decorated_function
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     return function(self, context, *args, **kwargs)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 294, in decorated_function
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     function(self, context, *args, **kwargs)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 271, in decorated_function
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     e, sys.exc_info())
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 258, in decorated_function
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     return function(self, context, *args, **kwargs)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 1792, in terminate_instance
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     do_terminate_instance(instance, bdms)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/openstack/common/lockutils.py", line 246, in inner
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     return f(*args, **kwargs)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 1784, in do_terminate_instance
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     reservations=reservations)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/hooks.py", line 105, in inner
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     rv = f(*args, **kwargs)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 1757, in _delete_instance
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     user_id=user_id)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 1729, in _delete_instance
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     self._shutdown_instance(context, db_inst, bdms)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 1662, in _shutdown_instance
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     requested_networks)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp   File "/opt/stack/nova/nova/compute/manager.py", line 1652, in _shutdown_instance
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp     context=context)
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp TypeError: destroy() got an unexpected keyword argument 'context'
  2013-10-25 23:03:20.764 TRACE nova.openstack.common.rpc.amqp

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1244829/+subscriptions