yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1237202] Re: run_tests.sh should run flake8 checks by default

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Wed, 04 Dec 2013 10:00:37 -0000
Reply-to: Bug 1237202 <1237202@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1237202

Title:
  run_tests.sh should run flake8 checks by default

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  People (myself included) often forget to run the tests with -p to
  check for pep8 issues, so the first patchset in a review often fails
  due to the pep8 checks in jenkins. It'd be better if ./run_tests.sh
  ran the flake8 checks by default so these were picked up earlier.

  I propose to run pep8 checks on any full test run. CI can continue to
  test unit tests and flake8 in isolation if we provide another command
  line option that disables the flake checks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1237202/+subscriptions