yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1237622

Title:
  vmware driver is not actually implementing get_diagnostics

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  According to the hypervisor support matrix the vmware driver doesn't
  support the diagnostics API:

  https://wiki.openstack.org/wiki/HypervisorSupportMatrix

  But the code suggests otherwise:

  https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/driver.py#L268

  https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L1263

  There is an unused get_diagnostics method in vmwareapi.vmops though:

  https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L1284

  i'm guessing that was stubbed out before the get_info method was added
  and someone connected the dots to the vmwareapi driver code to use it.

  We should remove the unused get_diagnostics method.

  Note that there aren't actually really any unit tests associated with
  the vmwareapi diagnostics API support though so we should add that in
  when we remove the unused method.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1237622/+subscriptions