← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1259425] Re: service-create allows 2 services with the same name

 

Reviewed:  https://review.openstack.org/65121
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=4ad37630a2f938b19697f6e310def046a4dcca48
Submitter: Jenkins
Branch:    master

commit 4ad37630a2f938b19697f6e310def046a4dcca48
Author: Juan Manuel Olle <juan.m.olle@xxxxxxxxx>
Date:   Mon Jan 6 15:07:09 2014 -0300

    Remove duplicated name services
    
    Due to the fact that keystone will not allow services with
    duplicated names, cinder and nova services names were
    changed
    
    Closes-Bug: #1259425
    Change-Id: I988aef477b418a289426e02e5e108aa57dd1076b


** Changed in: devstack
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1259425

Title:
  service-create allows 2 services with the same name

Status in devstack - openstack dev environments:
  Fix Released
Status in OpenStack Identity (Keystone):
  In Progress

Bug description:
  While `service-get <name>` seems to be confused by the duplicated
  name. The same thing happens to `service-delete <name>`. Of course,
  getting and deleting services by ID is not affected.

  Following http://docs.openstack.org/trunk/install-
  guide/install/apt/content/cinder-controller.html:

  $ keystone service-create --name=cinder --type=volume --description="Cinder Volume Service"
  +-------------+----------------------------------+
  |   Property  |              Value               |
  +-------------+----------------------------------+
  | description |      Cinder Volume Service       |
  |      id     | 54f9153b21b54a908562d85392784992 |
  |     name    |              cinder              |
  |     type    |              volume              |
  +-------------+----------------------------------+
  $ keystone service-create --name=cinder --type=volumev2 --description="Cinder Volume Service V2"
  +-------------+----------------------------------+
  |   Property  |              Value               |
  +-------------+----------------------------------+
  | description |     Cinder Volume Service V2     |
  |      id     | dd425789606b4472b32d78a63942aefc |
  |     name    |              cinder              |
  |     type    |             volumev2             |
  +-------------+----------------------------------+
  $ keystone service-get cinder
  global name 'exc' is not defined

  Debug output is here http://pastebin.com/kVJGUCwA

  I'm not sure whether duplicated names are allowed/recommended, but at
  least one of the following is needed:

    - service-create should check the name and stop when a service with the same name exists
    - service-get and service-delete should be changed so that they work with duplicated names, maybe by showing multiple services or reporting an appropriate error
    - The help text of service-get and service-delete should not say that name is allowed

To manage notifications about this bug go to:
https://bugs.launchpad.net/devstack/+bug/1259425/+subscriptions


References