yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1255680

Title:
  ml2: too many port_update notifications  sent because of port binding

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  process_port_binding is always called when a port is updated:
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L617

  However, its current implementation: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L202
  Return True, hence triggering a notification in many cases.

  The code has a check for returning false when the host is not set and
  the vif is already bound:
  https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L213

  However, this is perhaps not triggered in many cases.
  As an example, in this job: http://logs.openstack.org/20/57420/9/experimental/check-tempest-devstack-vm-neutron-isolated-parallel/269a314

  Of 538 update_port calls to the plugin, process_port_binding turns
  need_port_update_notify from False to Truue in

  It is therefore worth ensuring no notification is sent if the host
  doesn't change (the other binding parameters should not change on
  update and even if they can they should not trigger a notification) in
  72 cases out of 82 cases where the flag was false before invoking
  process_port_binding

  Looking at the logs - the port should not have been notified because
  of bindings in any case.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1255680/+subscriptions