← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1269200] Re: Remove unused arg `instances`

 

** Changed in: horizon
       Status: Fix Committed => Fix Released

** Changed in: horizon
    Milestone: None => icehouse-2

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1269200

Title:
  Remove unused arg `instances`

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In function VolumeTableMixIn._set_id_if_nameless(), we define arg
  `instances`, but we never use it.

  the codes snippet in file
  openstack_dashboard/dashboards/project/volumes/views.py:

  def _set_id_if_nameless(self, volumes, instances):
          for volume in volumes:
              # It is possible to create a volume with no name through the
              # EC2 API, use the ID in those cases.
              if not volume.display_name:
                  volume.display_name = volume.id

  and  should remove it  to keep the code clean.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1269200/+subscriptions


References