yahoo-eng-team team mailing list archive

[Launchpad Bug Tracker <1237425@xxxxxxxxxxxxxxxxxx>]

[Expired for neutron because there has been no activity for 60 days.]

** Changed in: neutron
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1237425

Title:
  assertTrue/assertFalse should be used instead of
  assertEqual(True/False,)

Status in OpenStack Neutron (virtual network service):
  Expired

Bug description:
  since there already have assertTrue, assertFalse methods, we should
  use the more suitable method.

  Note, this is not a real bug, just code refactor

  
  zqfan:neutron$ egrep -n 'assertEqual\(True,' neutron -r
  neutron/tests/unit/nicira/test_maclearning.py:100:            self.assertEqual(True, port['port']['mac_learning_enabled'])
  neutron/tests/unit/nicira/test_maclearning.py:104:            self.assertEqual(True, sport['port']['mac_learning_enabled'])
  neutron/tests/unit/nicira/test_maclearning.py:118:            self.assertEqual(True, res['port']['mac_learning_enabled'])
  neutron/tests/unit/nicira/test_maclearning.py:129:            self.assertEqual(True, res['port']['mac_learning_enabled'])
  neutron/tests/unit/nicira/test_maclearning.py:133:            self.assertEqual(True, sport['port']['mac_learning_enabled'])
  neutron/tests/unit/nicira/test_maclearning.py:145:                self.assertEqual(True, port['mac_learning_enabled'])
  neutron/tests/unit/nicira/test_maclearning.py:151:            self.assertEqual(True, port_res['mac_learning_enabled'])

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1237425/+subscriptions