← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1271706] Re: Misleading warning about MySQL TRADITIONAL mode not being set

 

** Also affects: nova
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1271706

Title:
  Misleading warning about MySQL TRADITIONAL mode not being set

Status in OpenStack Compute (Nova):
  New
Status in Oslo - a Library of Common OpenStack Code:
  Fix Committed

Bug description:
  common.db.sqlalchemy.session logs a scary warning if create_engine is
  not being called with mysql_traditional_mode set to True:

  WARNING keystone.openstack.common.db.sqlalchemy.session [-] This
  application has not enabled MySQL traditional mode, which means silent
  data corruption may occur. Please encourage the application developers
  to enable this mode.

  That warning is problematic for several reasons:

  (1) It suggests the wrong mode. Arguably TRADITIONAL is better than the default, but STRICT_ALL_TABLES would actually be more useful.
  (2) The user has no way to fix the warning.
  (3) The warning does not take into account that a global sql-mode may in fact have been set via the server-side MySQL configuration, in which case the session *may* in fact be using TRADITIONAL mode all along, despite the warning saying otherwise. This makes (2) even worse.

  My suggested approach would be:
  - Remove the warning.
  - Make the SQL mode a config option.

  Patches forthcoming.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1271706/+subscriptions