yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1231215

Title:
  to_xml should be used in post_live_migration_at_destination method

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  in the post_live_migration_at_destination method, the to_xml method is called but the return value never be used, and the comment say that the reason is 'the uuid is not included in to_xml() result'.
  but I think the uuid is already  included in to_xml() result now, so we may refactor post_live_migration_at_destination method and change it to use the correct way to get the xml of migrated instance.

  # In case of block migration, destination does not have
  # libvirt.xml
  disk_info = blockinfo.get_disk_info(CONF.libvirt_type,
                                      instance)
  self.to_xml(instance, network_info, disk_info,
              block_device_info, write_to_disk=True)
  # libvirt.xml should be made by to_xml(), but libvirt
  # does not accept to_xml() result, since uuid is not
  # included in to_xml() result.
  dom = self._lookup_by_name(instance["name"])
  self._conn.defineXML(dom.XMLDesc(0))

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1231215/+subscriptions