← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1258041] Re: Unit test can not make sense in tests for availability_zones.reset_cache

 

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1258041

Title:
  Unit test can not make sense in tests for
  availability_zones.reset_cache

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  In test_availability_zones.py and and test_compute.py,  There are two
  tests for availability_zones.reset_cache which can not make sense.

  Follow code:
          az.reset_cache()
          self.assertIsNone(az._get_cache().get('cache'))

  if we do not add cache for key 'cache',  the result of az._get_cache().get('cache') before  az.reset_cache() is same as after  az.reset_cache(). So it can not make sense.
  In test_compute.py, the wrong is in https://github.com/openstack/nova/blob/master/nova/tests/compute/test_compute.py#L8463

  the change for test_compute.py is in my another review
  https://review.openstack.org/#/c/59922/,

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1258041/+subscriptions


References