← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1246276] Re: xenapi: issues with destroy_vdi masking real errors

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => icehouse-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1246276

Title:
  xenapi: issues with destroy_vdi masking real errors

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  In cleaning up VDIs we call destroy_vdi.

  However, should the destroy fail, it masks the real error, for
  example:

  Unable to destroy VDI OpaqueRef:f53f35a9-31e1-af85-87a8-aa0dc7eecd43
    nova/compute/manager.py", _build_instance
  ...
    nova/virt/xenapi/vmops.py", line, in _attach_disks
      DEVICE_SWAP, name_label, swap_mb)
    nova/virt/xenapi/vm_utils.py", line, in generate_swap
      'swap', swap_mb, fs_type)
   nova/virt/xenapi/vm_utils.py", line, in _generate_disk
      destroy_vdi(session, vdi_ref)
    nova/virt/xenapi/vm_utils.py", line, in destroy_vdi
      _('Unable to destroy VDI %s') % vdi_ref)

  We should instead use the safe_destroy_vdi call.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1246276/+subscriptions