← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1289696] [NEW] request_id middleware uses wrong request ID value

 

Public bug reported:

The request_id middleware is designed to generate a request ID during
process_request() and attach this value to the as an HTTP header during
process_response(). Unfortunately, it stores the request ID value in a
variable within the RequestIdMiddleware class. This violates the "shared
nothing" rule, and can cause problems when several requests are run
concurrently. For example, if requests A and B come in back-to-back, and
A completes first, A will have B's request ID value in the HTTP
response.

This problem was discovered when running nova's
api.compute.servers.test_instance_actions test in parallel while working
on  https://review.openstack.org/#/c/66903/

** Affects: cinder
     Importance: Undecided
         Status: New

** Affects: neutron
     Importance: Undecided
         Status: New

** Affects: oslo
     Importance: Undecided
         Status: New

** Also affects: neutron
   Importance: Undecided
       Status: New

** Also affects: cinder
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1289696

Title:
  request_id middleware uses wrong request ID value

Status in Cinder:
  New
Status in OpenStack Neutron (virtual network service):
  New
Status in Oslo - a Library of Common OpenStack Code:
  New

Bug description:
  The request_id middleware is designed to generate a request ID during
  process_request() and attach this value to the as an HTTP header
  during process_response(). Unfortunately, it stores the request ID
  value in a variable within the RequestIdMiddleware class. This
  violates the "shared nothing" rule, and can cause problems when
  several requests are run concurrently. For example, if requests A and
  B come in back-to-back, and A completes first, A will have B's request
  ID value in the HTTP response.

  This problem was discovered when running nova's
  api.compute.servers.test_instance_actions test in parallel while
  working on  https://review.openstack.org/#/c/66903/

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1289696/+subscriptions


Follow ups

References